Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#24 - Smarter anonymization #33

Merged
merged 6 commits into from
Jul 4, 2022
Merged

#24 - Smarter anonymization #33

merged 6 commits into from
Jul 4, 2022

Conversation

michalbiarda
Copy link
Contributor

@michalbiarda michalbiarda commented Jun 30, 2022 •
edited
Loading

  • I rebuilt Anonymize command so it always convert same value of specific type to the same random value
  • I added UpdateValues command to allow smart update of grid tables (after source tables are anonymized)

See also: swiftotter/Driver-Magento2#9

@michalbiarda michalbiarda mentioned this pull request Jun 30, 2022
Merged
JesseMaxwell
JesseMaxwell approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@JesseMaxwell JesseMaxwell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one nitpick. Also, I do suggest we keep the region and region_id anonymizers as an option

.driver/anonymize.yaml Show resolved Hide resolved
src/Engines/MySql/Transformation/UpdateValues.php Outdated Show resolved Hide resolved
@michalbiarda michalbiarda merged commit ac7f0a6 into 4.0-develop Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseMaxwell JesseMaxwell JesseMaxwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalbiarda @JesseMaxwell